Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing lb / ag replacement #55546

Merged
merged 1 commit into from
Apr 22, 2019
Merged

fixing lb / ag replacement #55546

merged 1 commit into from
Apr 22, 2019

Conversation

zikalino
Copy link
Contributor

SUMMARY

When replacing LoadBalancer with Application Gateway in existing VMSS, load balancer was not removed.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_virtualmachinescaleset

ADDITIONAL INFORMATION

@zikalino zikalino requested a review from yungezz April 19, 2019 01:41
@ansibot
Copy link
Contributor

ansibot commented Apr 19, 2019

cc @haroldwongms @nitzmahone @sozercan @trstringer @xscript @yuwzho
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 azure bug This issue/PR relates to a bug. cloud community_review In order to be merged, this PR must follow the community review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. small_patch support:community This issue/PR relates to code supported by the Ansible community. labels Apr 19, 2019
@ansibleazurebot ansibleazurebot mentioned this pull request Apr 19, 2019
Closed
@yuwzho
Copy link
Contributor

yuwzho commented Apr 22, 2019

shipit

@yungezz
Copy link
Contributor

yungezz commented Apr 22, 2019

pls backport this fix.

@yungezz
Copy link
Contributor

yungezz commented Apr 22, 2019

shipit

@ansibot ansibot added automerge This PR was automatically merged by ansibot. shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. labels Apr 22, 2019
@ansibot ansibot merged commit 71494c0 into ansible:devel Apr 22, 2019
@zikalino zikalino deleted the fixed-lb-ag-replacemen-in-vmss branch April 23, 2019 01:34
zikalino pushed a commit to VSChina/ansible that referenced this pull request Apr 24, 2019
fixing lb / ag replacement (ansible#55546)
afe5635 
(cherry picked from commit 71494c0)
abadger pushed a commit that referenced this pull request Apr 24, 2019
@abadger
fixing lb / ag replacement (#55546)
8b88eec 
(cherry picked from commit 71494c0)
@ansible ansible locked and limited conversation to collaborators Jul 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yuwzho yuwzho yuwzho approved these changes

@yungezz yungezz Awaiting requested review from yungezz

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 automerge This PR was automatically merged by ansibot. azure bug This issue/PR relates to a bug. cloud module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. shipit This PR is ready to be merged by Core small_patch support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zikalino @ansibot @yuwzho @yungezz